Update gRPC TLS endpoint to default to 80 for HTTP for backwards compat. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Souza <[email protected]>
JoshVanL
requested changes
May 9, 2024
JoshVanL
approved these changes
May 9, 2024
cicoyle
approved these changes
May 9, 2024
|
+1 binding |
yaron2
approved these changes
May 9, 2024
|
+1 binding |
elena-kolevska
approved these changes
May 10, 2024
|
Even though I doubt anyone used port 443 without TLS, technically this is a breaking change, and we should remember to document it in the SDKs, once we implement it. |
mukundansundar
approved these changes
Jun 5, 2024
|
+1 binding |
1 similar comment
|
+1 binding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update gRPC TLS endpoint to default to 80 for HTTP for backwards compatibility.
This regression was detected by an existing unit test at the Java SDK while implementing the updated version of this spec.
Addressing #56